Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): integrate server-hstore into hugegraph #2534

Merged
merged 8 commits into from
May 6, 2024
Merged

Conversation

VGalaxies
Copy link
Contributor

@VGalaxies VGalaxies commented Apr 26, 2024

subtask of #2265

When introducing hstore, server-core needs corresponding modifications. Except for BytesBuffer.java in hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/serializer/, other files should be consistent with the pd-store branch.

@VGalaxies VGalaxies added the hstore Hstore backend label Apr 26, 2024
@VGalaxies VGalaxies requested a review from imbajin April 26, 2024 06:30
@VGalaxies VGalaxies self-assigned this Apr 26, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feature New feature labels Apr 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 22.40664% with 187 lines in your changes are missing coverage. Please review.

Project coverage is 56.87%. Comparing base (2b3bc4f) to head (a441f4e).

Files Patch % Lines
...gegraph/backend/query/serializer/QueryAdapter.java 12.32% 64 Missing ⚠️
...apache/hugegraph/backend/query/ConditionQuery.java 13.51% 32 Missing ⚠️
.../org/apache/hugegraph/backend/query/Condition.java 7.14% 24 Missing and 2 partials ⚠️
.../java/org/apache/hugegraph/type/HugeTableType.java 0.00% 22 Missing ⚠️
...nd/query/serializer/AbstractSerializerAdapter.java 8.33% 11 Missing ⚠️
...ache/hugegraph/backend/serializer/BytesBuffer.java 0.00% 11 Missing ⚠️
...java/org/apache/hugegraph/backend/query/Query.java 68.18% 6 Missing and 1 partial ⚠️
...gegraph/backend/serializer/BinaryBackendEntry.java 0.00% 4 Missing ⚠️
.../hugegraph/backend/store/AbstractBackendStore.java 0.00% 3 Missing ⚠️
.../main/java/org/apache/hugegraph/type/HugeType.java 50.00% 1 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2534      +/-   ##
============================================
- Coverage     57.14%   56.87%   -0.28%     
- Complexity      827      829       +2     
============================================
  Files           608      612       +4     
  Lines         49415    49649     +234     
  Branches       6645     6673      +28     
============================================
- Hits          28238    28236       -2     
- Misses        18361    18597     +236     
  Partials       2816     2816              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

</dependency>
<dependency>
<groupId>org.apache.hugegraph</groupId>
<artifactId>hg-store-client</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer hg => hugegraph

Copy link
Member

@imbajin imbajin Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer hg => hugegraph

we'll delete all prefix together later (include change the name of server)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 6, 2024
@imbajin imbajin merged commit c1e8ea5 into master May 6, 2024
14 checks passed
@imbajin imbajin deleted the intro-hstore branch May 6, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature hstore Hstore backend lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants