Support range sortKey feature #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
force-pushed
the
range-sortkey
branch
5 times, most recently
from
9fafb06 to
2692c3d
Compare
Linary
requested changes
Dec 25, 2018
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/UnitTestSuite.java
Show resolved
Hide resolved
javeme
force-pushed
the
range-sortkey
branch
3 times, most recently
from
3d470cb to
405be06
Compare
Linary
requested changes
Dec 26, 2018
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/ConditionQuery.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/IdPrefixQuery.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/IdPrefixQuery.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/IdRangeQuery.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/IdRangeQuery.java
Show resolved
Hide resolved
javeme
force-pushed
the
range-sortkey
branch
from
405be06 to
0cdbd21
Compare
zhoney
requested changes
Dec 26, 2018
| int cmp1 = Bytes.compare(element.id().asBytes(), this.start.asBytes()); | ||
| int cmp2 = Bytes.compare(element.id().asBytes(), this.end.asBytes()); | ||
| return (this.inclusiveStart ? cmp1 >= 0 : cmp1 > 0) && | ||
| (this.inclusiveEnd ? cmp2 <= 0 : cmp1 < 0); |
There was a problem hiding this comment.
(this.inclusiveEnd ? cmp2 <= 0 : cmp2 < 0);
| @@ -136,6 +165,17 @@ public HugeType type() { | |||
| return valid; | |||
| } | |||
|
|
|||
| public <V> Object serialValue(V value) { | |||
| V validValue = this.validValue(value); | |||
| E.checkArgument(value != null, | |||
| graph.tx().commit(); | ||
| System.exit(0); |
javeme
force-pushed
the
range-sortkey
branch
from
0cdbd21 to
cd163d0
Compare
Linary
requested changes
Dec 27, 2018
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/IdPrefixQuery.java
Show resolved
Hide resolved
|
|
||
| public IdPrefixQuery(Query originQuery, | ||
| Id start, boolean inclusiveStart, Id prefix) { | ||
| this(originQuery.resultType(), originQuery, start, true, prefix); |
Linary
requested changes
Dec 27, 2018
| assert condition instanceof Condition.Relation; | ||
| Condition.Relation r = (Condition.Relation) condition; | ||
| Condition.Relation sys = new Condition.SyspropRelation( | ||
| HugeKeys.SORT_VALUES, |
implement #271 Change-Id: Ib618c45bc6169a0fb7632dbbf0fb29b7ee0a08e3
javeme
force-pushed
the
range-sortkey
branch
from
cd163d0 to
171b33a
Compare
Linary
approved these changes
Dec 29, 2018
zhoney
approved these changes
Dec 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement #271
Change-Id: Ib618c45bc6169a0fb7632dbbf0fb29b7ee0a08e3