improve schema serialization in BinarySerializer #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linary
force-pushed
the
schema-serializer
branch
3 times, most recently
from
670bfbb to
a381049
Compare
javeme
requested changes
Jan 4, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
javeme
previously requested changes
Jan 4, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
Linary
force-pushed
the
schema-serializer
branch
2 times, most recently
from
91b7847 to
822c9e6
Compare
javeme
requested changes
Jan 7, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
Linary
force-pushed
the
schema-serializer
branch
2 times, most recently
from
905bfd5 to
4bd8271
Compare
javeme
previously requested changes
Jan 7, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
Linary
force-pushed
the
schema-serializer
branch
from
4bd8271 to
1b70a41
Compare
javeme
requested changes
Jan 8, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
zhoney
previously approved these changes
Jan 8, 2019
Linary
force-pushed
the
schema-serializer
branch
from
1b70a41 to
8624a9f
Compare
javeme
requested changes
Jan 8, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Show resolved
Hide resolved
| return serializer.readIndexLabel(graph, entry); | ||
| } | ||
|
|
||
| private final class SchemaSerializer { |
There was a problem hiding this comment.
used member method newBackendEntry
Improve #248 Change-Id: Ieb0734f21c7d1cda3a3f586048109da048c307d7
Linary
force-pushed
the
schema-serializer
branch
from
8624a9f to
cb85435
Compare
javeme
approved these changes
Jan 8, 2019
zhoney
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve #248
Change-Id: Ieb0734f21c7d1cda3a3f586048109da048c307d7