Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHADE-371] Update Shade Apache[Notice/LICENSE] ResourceTransformer to use [NOTICE/LICENSE].md #51

Closed
wants to merge 3 commits into from

Conversation

johnmillner
Copy link
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSHADE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSHADE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

for

  • org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer
  • org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer
    there is no check for LISENCE.md or NOTICE.md

small PR wanted to add that in along with the checks for LISENCE/LISENCE.txt and NOTICE/NOTICE.txt

@johnmillner
Copy link
Contributor Author

@elharo elharo changed the title MSHADE-371 - Update Shade Apache[Notice/LISENCE]ResourceTransformer to use [NOTICE/LISENCE].md [MSHADE-371] Update Shade Apache[Notice/LICENSE] ResourceTransformer to use [NOTICE/LICENSE].md Jun 25, 2020
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a test.

@asfgit asfgit closed this in ba0cc3c Jun 27, 2020
@johnmillner johnmillner deleted the patch-1 branch June 28, 2020 01:48
@vitalijr2
Copy link

vitalijr2 commented Dec 26, 2021

Could you reopen this PR? Not needed, it was merged.

@slachiewicz
Copy link
Member

It has been merged to master branch and will be part of next release. Why we should reopen PR?

@vitalijr2
Copy link

It's marked as closed not merged. So I have thought that it was declined as there are no tests.

Then I have checked Git history and found these changes are in master. I have edited my previous comment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants