Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSHARED-1109] Ignore MessageUtilsTest methods on unsupported platforms #106

Merged
merged 1 commit into from
Jul 25, 2022
Merged

[MSHARED-1109] Ignore MessageUtilsTest methods on unsupported platforms #106

merged 1 commit into from
Jul 25, 2022

Conversation

kwin
Copy link
Member

@kwin kwin commented Jul 25, 2022

No description provided.

@kwin
Copy link
Member Author

kwin commented Jul 25, 2022

I don't think the test failure is related (https://github.com/apache/maven-shared-utils/runs/7501384171?check_suite_focus=true)

Error:  Failures: 
Error:    MessageUtilsTest.testSystem:50 
Expected: sameInstance(<org.apache.maven.surefire.report.ConsoleOutputCapture$ForwardingPrintStream@12d3a4e9>)
     but: was <AnsiPrintStream{type=Redirected, colors=Colors16, mode=Strip, resetAtUninstall=true}>

@michael-o
Copy link
Member

I don't think the test failure is related (https://github.com/apache/maven-shared-utils/runs/7501384171?check_suite_focus=true)

Error:  Failures: 
Error:    MessageUtilsTest.testSystem:50 
Expected: sameInstance(<org.apache.maven.surefire.report.ConsoleOutputCapture$ForwardingPrintStream@12d3a4e9>)
     but: was <AnsiPrintStream{type=Redirected, colors=Colors16, mode=Strip, resetAtUninstall=true}>

Correct, since the test expect Jansi to work it does not notice that the OS is not wrapped.

michael-o
michael-o approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the issue on HP-UX for me as well.

michael-o pushed a commit to kwin/maven-shared-utils that referenced this pull request Jul 25, 2022
@kwin @michael-o
[MSHARED-1109] MessageUtilsTest fails on unsupported platforms (e.g.,…
3f380dd 
… Apple Silicon or HP-UX/IA64)

This closes apache#106
@michael-o michael-o force-pushed the bugfix/fix-messageutilstest-on-apple-silicon branch from 65157b0 to 3f380dd Compare July 25, 2022 14:18
@michael-o michael-o force-pushed the bugfix/fix-messageutilstest-on-apple-silicon branch from 3f380dd to 8822bea Compare July 25, 2022 14:21
@asfgit asfgit merged commit 8822bea into apache:master Jul 25, 2022
@slawekjaranowski slawekjaranowski added the bug Something isn't working label Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kwin @michael-o @asfgit @slawekjaranowski