Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to maven 3.2.5 + Java8 #73

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Upgrade to maven 3.2.5 + Java8 #73

merged 1 commit into from
Apr 16, 2022

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Feb 22, 2022

Upgrade plugin to Maven 3.2.5

This will have ITs failed, as there is some bug re XML encoded it ISO5592-1. If you search/replace all ISO8859-1 (and convert files) -- there is site-sd-lang that uses french ISO -- so all to UTF-8 and files converted as well, then all IT pass OK.

@cstamas cstamas requested a review from michael-o February 22, 2022 15:40
@cstamas cstamas self-assigned this Feb 22, 2022
cstamas added a commit that referenced this pull request Feb 22, 2022
When all the XMLs are converted to UTF8
@olamy
Copy link
Member

olamy commented Feb 23, 2022

there is already some work on java 8 here #21

@asfgit asfgit force-pushed the maven-3.2.5 branch 3 times, most recently from a7be5b4 to c965c21 Compare April 16, 2022 19:20
@asfgit asfgit closed this in 32be6ad Apr 16, 2022
@asfgit asfgit merged commit 32be6ad into master Apr 16, 2022
@michael-o michael-o deleted the maven-3.2.5 branch April 16, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants