-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/net: update format specifier on lan9250 driver #15915
Conversation
Can we go forward with this? |
Unfortunately, we need to wait until more people vote, I wish more people were actually interested in becoming reviewers. By the way, are you interested in becoming a reviewer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fdcavalcanti :-)
- The
uint16_t address
should use0x%04"PRIx16
as 8-bit data is represented by two ascii hex while 16-bit by four ascii hex right? - If we use
0x%02"PRIx8
foruint16_t
type then half of the data is cut. - Personally I prefer
PRIX16
in order to get upper case ascii hex but the code uses already lowercase so its okay to leave its lowercase :-P
Well, most of us are volunteers working in a so called free moments so its not always possible to respond rapidly as we would wish, help is needed.. for instance its 0308AM Friday/Saturday night here and I just did my first Saturday coffee "today" :D :D |
Sorry about the delay. Carnival week here in Brazil :) |
Fix print statement for uint8 and uint16 types. Signed-off-by: Filipe Cavalcanti <[email protected]>
83bcb69
to
f4f6108
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fdcavalcanti :-)
CI failed, seems random, restarted. lets wait for the all tests to complete before merge :-) |
Allright CI passed :-) |
Summary
Fix print statement for uint8 and uint16 types.
Required due to efforts on fixing #15755 .
I had recently sent a PR on this same driver but missed a couple of lines.
Error example:
Impact
_int32_t
and_uint32_t
#15755. It can be merged now since it won't affect current builds.Testing
This test simply builds the binary and checks for compilation errors.
Unfortunately I don't have this device to test (requires external LAN9250). If someone has, please speak up!
Building
Results
No build errors.