net/can: fix timestamp #15952
Merged
net/can: fix timestamp #15952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Networking
|
@PetervdPerk FYI |
jerpelea
approved these changes
Mar 7, 2025
PetervdPerk-NXP
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
LGTM Fixes regression from #7616
By restoring to original correct implementation.
lupyuen
approved these changes
Mar 7, 2025
Fix timestamp in socket CAN. Right now the timestamp is only generated if there is no reader and the frame is stored in the read ahead list. This is solved by moving the timestamp generation before the code flow branch. Signed-off-by: Javier Casas <[email protected]>
occam25
force-pushed
the
Fix_timestamp_in_socket_CAN
branch
from
1bf09d0 to
12396a2
Compare
|
@lupyuen sorry about that, I forgot to add the description and the signature. I have added both now. Thanks! |
acassis
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix timestamp in socket CAN. Right now the timestamp is only generated if there is no reader and the frame is stored in the read ahead list. This is solved by moving the timestamp generation before the code flow branch.
Impact
This has no impact other than having the timestamp working again.
Testing
As discussed in the mailing list, I have tested this fix in our current branch that is older than main. I can't test it on main because our whole system would not even compile. Updating the system to the latest Nuttx is a pending task in our backlog but it will take quite some time. Nevertheless, since this is a small change that doesn't add any new code but just moves the timestamp generation it may be worth to consider it.