fix(services/s3): Batch max operations from config #2354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into batch_max_operations-from-config
…/manulpatel/incubator-opendal into batch_max_operations-from-config
Xuanwo
reviewed
May 29, 2023
| @@ -314,6 +314,8 @@ pub struct S3Builder { | |||
| /// the part size of s3 multipart upload, which should be 5 MiB to 5 GiB. | |||
| /// There is no minimum size limit on the last part of your multipart upload | |||
| write_min_size: Option<usize>, | |||
|
|
|||
There was a problem hiding this comment.
Please add a new function for batch_max_operations so that users can assign it.
…/manulpatel/incubator-opendal into batch_max_operations-from-config
|
The next step is load |
xyjixyjixyji
reviewed
Jun 2, 2023
| @@ -19,6 +19,7 @@ use std::collections::HashMap; | |||
| use std::fmt::Debug; | |||
| use std::fmt::Formatter; | |||
| use std::fmt::Write; | |||
| use std::string; | |||
There was a problem hiding this comment.
I am not seeing why we need to use std::string here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #2228
This PR allows to read
batch_max_operationsfrom config and takes default value of 1000 if not specified explicity.