Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindings/swift): reorg the package to correct its name #2479

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

unixzii
Copy link
Contributor

@unixzii unixzii commented Jun 17, 2023

Swift packages take the name of their enclosing directories as the package name. Users want to use OpenDAL to refer to this package, instead of swift currently.

To do so, we need to put the package contents into a subdirectory named OpenDAL.

This PR also fixes some other minor issues:

  • Use absolute path in linker options.
  • Remove unused rule commands in Makefile.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 95e7a19 into apache:main Jun 18, 2023
@unixzii unixzii mentioned this pull request Jun 18, 2023
6 tasks
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants