Add zip+tar to publishable artifacts and add a run.sh script
#1082
Conversation
Adds the tar+zip distribution archives as publishable artifacts to Maven publication. Also updates polaris-quarkus-admin to build as a "fast-jar" instead of an "uber-jar".
snazy
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
|
This is a prerequisite for #785 |
| } | ||
|
|
||
| quarkus { | ||
| quarkusBuildProperties.put("quarkus.package.type", "uber-jar") | ||
| quarkusBuildProperties.put("quarkus.package.type", "fast-jar") |
There was a problem hiding this comment.
Isn't this going to complicate the tool usage? It's easier to download and run a single jar than to download a zip, unpack, then run.
There was a problem hiding this comment.
I agree that uber-jar is more convenient for the admin tool.
There was a problem hiding this comment.
AFAIU the current approach it is already a tgz/zip file that needs to be extracted, because of the necessary LICENSE/NOTICE files.
There was a problem hiding this comment.
Could we include the NOTICE test into the user jar and have a CLI option to print it?
There was a problem hiding this comment.
Uber jar is also an option: we can ship LICENSE/NOTICE in the meta-inf. By the way, I'm working on the license and notice content for binary distributions.
| contents { | ||
| from(runScript) | ||
| from(project.layout.buildDirectory.dir("quarkus-app")) | ||
| from("../../NOTICE") |
There was a problem hiding this comment.
IMHO it's better to square the license/notice on the target artifacts. I can change that in second step along with license/notice.
Adds the tar+zip distribution archives as publishable artifacts to Maven publication.
Also updates polaris-quarkus-admin to build as a "fast-jar" instead of an "uber-jar".