Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry v2 #898

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Poetry v2 #898

wants to merge 8 commits into from

Conversation

MonkeyCanCode
Copy link
Contributor

@MonkeyCanCode MonkeyCanCode commented Jan 28, 2025

This is for additional changes for Poetry v2 where we will be migrating existed project to PEP 621-style configuration.

Here are the summary for the changes:

  1. Make pyproject.tom PEP 621-compliant
  2. Use poetry-core for the build system instead of setuptools
  3. Remove reference for setuptools
  4. Remove non-essential dependencies (flake8, pylint, types-python-dateutil, mypy) for running tests and introduce a test group in Poetry (if those tools are needed, we can do a new group for dev instead?)

The final pyproject.toml is validated via validate-pyproject:

(venv) ➜  python git:(poetry_v2) ✗ validate-pyproject pyproject.toml
Valid file: pyproject.toml

Here is the non-docker test status:

Mon Jan 27 23:34:19 CST 2025: Test SUCCEEDED: t_cli:test_cli.py
Mon Jan 27 23:34:19 CST 2025: Starting test t_hello_world:hello_world.sh
Mon Jan 27 23:34:19 CST 2025: Test run concluded for t_hello_world:hello_world.sh
Mon Jan 27 23:34:19 CST 2025: Test SUCCEEDED: t_hello_world:hello_world.sh
Mon Jan 27 23:34:19 CST 2025: Starting pytest t_pyspark:test_spark_sql_s3_with_privileges.py
...
Mon Jan 27 23:34:21 CST 2025: Test SUCCEEDED: t_pyspark:test_spark_sql_s3_with_privileges.py
Mon Jan 27 23:34:21 CST 2025: Azure tests not enabled, skip running test t_spark_sql/src/spark_sql_azure_dfs.sh
Mon Jan 27 23:34:21 CST 2025: GCS tests not enabled, skip running test t_spark_sql/src/spark_sql_gcp.sh
Mon Jan 27 23:34:21 CST 2025: Azure tests not enabled, skip running test t_spark_sql/src/spark_sql_azure_blob.sh
Mon Jan 27 23:34:21 CST 2025: Starting test t_spark_sql:spark_sql_views.sh
Mon Jan 27 23:34:34 CST 2025: Test run concluded for t_spark_sql:spark_sql_views.sh
Mon Jan 27 23:34:34 CST 2025: Test SUCCEEDED: t_spark_sql:spark_sql_views.sh
Mon Jan 27 23:34:34 CST 2025: AWS tests not enabled, skip running test t_spark_sql/src/spark_sql_s3.sh
Mon Jan 27 23:34:34 CST 2025: AWS cross region tests not enabled, skip running test t_spark_sql/src/spark_sql_s3_cross_region.sh
Mon Jan 27 23:34:34 CST 2025: Starting test t_spark_sql:spark_sql_basic.sh
Mon Jan 27 23:34:45 CST 2025: Test run concluded for t_spark_sql:spark_sql_basic.sh
Mon Jan 27 23:34:45 CST 2025: Test SUCCEEDED: t_spark_sql:spark_sql_basic.sh
Mon Jan 27 23:34:45 CST 2025: Tests completed with 3 successes and 0 failures

Here is the docker test status:

...
regtest-1  | Tue Jan 28 04:44:41 AM UTC 2025: Test run concluded for t_spark_sql:spark_sql_views.sh
regtest-1  | Tue Jan 28 04:44:41 AM UTC 2025: Test SUCCEEDED: t_spark_sql:spark_sql_views.sh
regtest-1  | Tue Jan 28 04:44:41 AM UTC 2025: Azure tests not enabled, skip running test t_spark_sql/src/spark_sql_azure_dfs.sh
regtest-1  | Tue Jan 28 04:44:41 AM UTC 2025: Tests completed with 3 successes and 0 failures
regtest-1 exited with code 0
Aborting on container exit
...

Noted, until 896 is merged, the github action will continue to fail for this one.

@MonkeyCanCode
Copy link
Contributor Author

@eric-maynard may I have a review this for this?

@MonkeyCanCode
Copy link
Contributor Author

@HonahX may i get a review for this one as well?

@MonkeyCanCode
Copy link
Contributor Author

@jbonofre may I have a review for this one? Seems to causing blockers for couple PRs in the last couple days and similar PR raised as well.

@jbonofre
Copy link
Member

jbonofre commented Mar 4, 2025

@MonkeyCanCode sure. I gonna take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants