-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry v2 #898
Open
MonkeyCanCode
wants to merge
8
commits into
apache:main
Choose a base branch
from
MonkeyCanCode:poetry_v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Poetry v2 #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
snazy
reviewed
Jan 28, 2025
@eric-maynard may I have a review this for this? |
@HonahX may i get a review for this one as well? |
1 task
HonahX
reviewed
Feb 7, 2025
@jbonofre may I have a review for this one? Seems to causing blockers for couple PRs in the last couple days and similar PR raised as well. |
@MonkeyCanCode sure. I gonna take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for additional changes for Poetry v2 where we will be migrating existed project to PEP 621-style configuration.
Here are the summary for the changes:
The final
pyproject.toml
is validated via validate-pyproject:Here is the non-docker test status:
Here is the docker test status:
Noted, until 896 is merged, the github action will continue to fail for this one.