-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade beefsack/go-rate #725
Comments
1 task
wolfstudy
pushed a commit
that referenced
this issue
Feb 22, 2022
Fixes #725 ### Motivation This PR will enable pulsar-client-go to be a compliant library. One of its dependencies was not compliant with OSS licensing requirements earlier, and this PR upgrades to the latest version of it, which has a MIT license. ### Modifications Ran the following commands ```bash go get github.com/beefsack/go-rate@latest go mod tidy ``` ### Verifying this change - [x] Make sure that the change passes the CI checks.
freeznet
pushed a commit
that referenced
this issue
Mar 8, 2022
Fixes #725 ### Motivation This PR will enable pulsar-client-go to be a compliant library. One of its dependencies was not compliant with OSS licensing requirements earlier, and this PR upgrades to the latest version of it, which has a MIT license. ### Modifications Ran the following commands ```bash go get github.com/beefsack/go-rate@latest go mod tidy ``` ### Verifying this change - [x] Make sure that the change passes the CI checks.
nodece
pushed a commit
that referenced
this issue
Sep 6, 2022
…ontent (#831) * Upgrade beefsack/go-rate (#735) Fixes #725 ### Motivation This PR will enable pulsar-client-go to be a compliant library. One of its dependencies was not compliant with OSS licensing requirements earlier, and this PR upgrades to the latest version of it, which has a MIT license. ### Modifications Ran the following commands ```bash go get github.com/beefsack/go-rate@latest go mod tidy ``` ### Verifying this change - [x] Make sure that the change passes the CI checks. * Upgrade prometheus client to 1.11.1 (#738) * remove redundant "[]" pair in the head and tail of log content Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Nicolò Boschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently, apache/pulsar-client-go depends on github.com/beefsack/go-rate v0.0.0-20180408011153-efa7637bb9b6, which has a GPL license. It is non-compliant with CNCF's third party dependency guidelines for anyone who consumes it.
Describe the solution you'd like
The latest version of https://github.com/beefsack/go-rate is MIT licensed. This proposal is to upgrade beefsack/go-rate in this library to achieve compliance.
Describe alternatives you've considered
There are alternate rate-limiting libraries too, like https://github.com/uber-go/ratelimit
The text was updated successfully, but these errors were encountered: