Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] add a lint-docker command in makefile #1207

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

geniusjoe
Copy link
Contributor

Motivation

I encountered install failure when I ran make lint to linter my code.
I think we may get some errors when local go env is a little bit complicated, and sometimes it is better to run linter in an official linter docker.

Modifications

I add an alternative make lint-docker Makefile command so that we can run linter in a docker file.

Verifying this change

  • Make sure that the change passes the CI checks.
    This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@BewareMyPower BewareMyPower added this to the v0.13.0 milestone Apr 22, 2024
@BewareMyPower BewareMyPower merged commit 13ecca2 into apache:master Apr 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants