Optimize code

apache · Nov 21, 2024 · e2a102f · e2a102f
1 parent 5bbca7c
commit e2a102f
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
@@ -3489,10 +3489,14 @@ private void updateResultIfNewer(OldestPositionInfo updatedResult) {
 
     public CompletableFuture<Void> updateOldPositionInfo() {
         TopicName topicName = TopicName.get(getName());
-        ManagedCursorContainer managedCursorContainer = (ManagedCursorContainer) ledger.getCursors();
-        CursorInfo oldestMarkDeleteCursorInfo = managedCursorContainer.getCursorWithOldestPosition();
+
+        if (!(ledger.getCursors() instanceof ManagedCursorContainer managedCursorContainer)) {
+            return CompletableFuture.failedFuture(new IllegalStateException(
+                    String.format("[%s] No valid cursors found. Skip update old position info.", topicName)));
+        }
 
         // If we have no durable cursor since `ledger.getCursors()` only managed durable cursors
+        CursorInfo oldestMarkDeleteCursorInfo = managedCursorContainer.getCursorWithOldestPosition();
         if (oldestMarkDeleteCursorInfo == null || oldestMarkDeleteCursorInfo.getPosition() == null) {
             if (log.isDebugEnabled()) {
                 log.debug("[{}] No durable cursor found. Skip update old position info.", topicName);