Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][sec] Upgrade to Netty 4.1.118 #23965

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

merlimat
Copy link
Contributor

Motivation

┌─────────────────────────────────────────────────────┬────────────────┬──────────┬──────────┬───────────────────┬───────────────┬───────────────────────────────────────────────────────────┐
│                       Library                       │ Vulnerability  │ Severity │  Status  │ Installed Version │ Fixed Version │                           Title                           │
├─────────────────────────────────────────────────────┼────────────────┼──────────┼──────────┼───────────────────┼───────────────┼───────────────────────────────────────────────────────────┤
│ io.netty:netty-handler                              │ CVE-2025-24970 │ HIGH     │ fixed    │ 4.1.117.Final     │ 4.1.118.Final │ Netty, an asynchronous, event-driven network application  │
│ (io.netty-netty-handler-4.1.117.Final.jar)          │                │          │          │                   │               │ framework, ha ...                                         │
│                                                     │                │          │          │                   │               │ https://avd.aquasec.com/nvd/cve-2025-24970                │
├─────────────────────────────────────────────────────┼────────────────┼──────────┤          ├───────────────────┼───────────────┼───────────────────────────────────────────────────────────┤

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added this to the 4.1.0 milestone Feb 11, 2025
@merlimat merlimat requested a review from lhotari February 11, 2025 18:24
@merlimat merlimat self-assigned this Feb 11, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.25%. Comparing base (bbc6224) to head (e313435).
Report is 900 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23965      +/-   ##
============================================
+ Coverage     73.57%   74.25%   +0.68%     
+ Complexity    32624    32281     -343     
============================================
  Files          1877     1853      -24     
  Lines        139502   143821    +4319     
  Branches      15299    16339    +1040     
============================================
+ Hits         102638   106795    +4157     
+ Misses        28908    28636     -272     
- Partials       7956     8390     +434     
Flag Coverage Δ
inttests 26.85% <ø> (+2.26%) ⬆️
systests 23.25% <ø> (-1.08%) ⬇️
unittests 73.77% <ø> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1040 files with indirect coverage changes

@lhotari lhotari changed the title Upgrade to Netty 4.1.118 [fix][sec] Upgrade to Netty 4.1.118 Feb 11, 2025
@lhotari lhotari merged commit 8ca91fd into apache:master Feb 11, 2025
53 of 54 checks passed
@merlimat merlimat deleted the netty-4.1.118 branch February 11, 2025 20:55
merlimat added a commit that referenced this pull request Feb 11, 2025
merlimat added a commit that referenced this pull request Feb 11, 2025
merlimat added a commit that referenced this pull request Feb 11, 2025
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Feb 19, 2025
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Feb 20, 2025
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants