[ZEPPELIN-6137] Fix Windows compile tests #4883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review required |
pan3793
approved these changes
Oct 24, 2024
jongyoul
approved these changes
Oct 24, 2024
asfgit
pushed a commit
that referenced
this pull request
Oct 24, 2024
### What is this PR for? This pull request changes the JDK for appveyor to JDK 11. Please note that only the “Visual Studio 2019” worker image has JDK 11 installed. “Visual Studio 2022”, on the other hand, does not have JDK 11 installed. Take a look into https://www.appveyor.com/docs/windows-images-software/#visual-studio-2022 ### What type of PR is it? Improvement ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-6137 ### How should this be tested? * appveyor tests ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4883 from Reamer/appveyor_jdk11. Signed-off-by: Philipp Dallig <[email protected]> (cherry picked from commit 0203ee5) Signed-off-by: Philipp Dallig <[email protected]>
|
Merged into master/branch-0.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This pull request changes the JDK for appveyor to JDK 11.
Please note that only the “Visual Studio 2019” worker image has JDK 11 installed. “Visual Studio 2022”, on the other hand, does not have JDK 11 installed. Take a look into https://www.appveyor.com/docs/windows-images-software/#visual-studio-2022
What type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
Questions: