[ZEPPELIN-6138] Update Apache Parent #4884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Oct 28, 2024
| .endObject() | ||
| .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)]) | ||
| .field("content_length", RandomUtils.nextInt(0, 2000)) | ||
| ) |
There was a problem hiding this comment.
can we keep the indent? the original one has better readability
There was a problem hiding this comment.
Thank you for your review. I have adjusted the indentation. How does it look now?
pan3793
reviewed
Oct 28, 2024
| .endObject() | ||
| .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)]) | ||
| .field("content_length", RandomUtils.nextInt(0, 2000)) | ||
| ).get(); |
pan3793
approved these changes
Oct 28, 2024
asfgit
pushed a commit
that referenced
this pull request
Oct 28, 2024
### What is this PR for? This pull request updates the Apache parent version. We benefit significantly from plugin updates and can clean up our own `pom.xml`. plugin updates: maven-antrun-plugin - 1.8 -> 3.1.0 maven-assembly-plugin - 3.7.1 -> 3.7.1 maven-clean-plugin - 3.1.0 -> 3.4.0 maven-compiler-plugin - 3.8.1 -> 3.13.0 maven-dependency-plugin - 3.1.2 -> 3.7.1 maven-deploy-plugin - 2.8.2 -> 3.1.2 maven-enforcer-plugin - 3.0.0-M3 -> 3.5.0 maven-gpg-plugin - 1.6 -> 3.2.4 apache-rat-plugin - 0.13 -> 0.16.1 surefire & failsafe version - 3.2.2 -> 3.3.0 ### What type of PR is it? Improvement ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-6138 ### How should this be tested? * CI ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4884 from Reamer/apacheParent. Signed-off-by: Philipp Dallig <[email protected]> (cherry picked from commit ea0802d) Signed-off-by: Philipp Dallig <[email protected]>
|
Merged into master/branch-0.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This pull request updates the Apache parent version. We benefit significantly from plugin updates and can clean up our own
pom.xml.plugin updates:
maven-antrun-plugin - 1.8 -> 3.1.0
maven-assembly-plugin - 3.7.1 -> 3.7.1
maven-clean-plugin - 3.1.0 -> 3.4.0
maven-compiler-plugin - 3.8.1 -> 3.13.0
maven-dependency-plugin - 3.1.2 -> 3.7.1
maven-deploy-plugin - 2.8.2 -> 3.1.2
maven-enforcer-plugin - 3.0.0-M3 -> 3.5.0
maven-gpg-plugin - 1.6 -> 3.2.4
apache-rat-plugin - 0.13 -> 0.16.1
surefire & failsafe version - 3.2.2 -> 3.3.0
What type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
Questions: