-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fingerprint datapoints python package #353
Conversation
pyproject.toml
Outdated
build-backend = "hatchling.build" | ||
|
||
[project] | ||
name = "fingerprint_datapoints" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no mentioning Apify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, renamed.
fingerprint_datapoints/LICENSE
Outdated
@@ -0,0 +1,201 @@ | |||
Apache License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't we use the license from the root dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. WIll reuse it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK I think, just some questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How frequently do you think we'll release this? Should we automate changelog generation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be on demand, only when there is reason to. But I do not expect periodic releases. So I would suggest adding automation only if my prediction proves wrong :D
requires = ["hatchling"] | ||
build-backend = "hatchling.build" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the benefits of using hatch
over uv
or poetry
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. I picked the same build-backend we use in crawlee. (Maybe there is better option, but I would rather stick with the same tool in our repos. If we decide to change it, lets do it for all repos.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the benefits of using hatch over uv or poetry?
uv
does not have its own backend (see astral-sh/uv#3957), and they recommend using hatchling
(it's from PyPA).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They do, see the same issue 😏 astral-sh/uv#3957 (comment) or Hynek's recent video https://www.youtube.com/watch?v=mFyE9xgeKcA
Co-authored-by: Jan Buchar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Failing CI due to unrelated issues: #355 |
Add simple Python package that contains fingerprint data and helpers to get them and release flow to push it to pypi.