Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fingerprint datapoints python package #353

Merged
merged 7 commits into from
Mar 10, 2025

Conversation

Pijukatel
Copy link
Contributor

Add simple Python package that contains fingerprint data and helpers to get them and release flow to push it to pypi.

@github-actions github-actions bot added this to the 109th sprint - Tooling team milestone Mar 4, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Mar 4, 2025
@Pijukatel Pijukatel requested review from janbuchar and vdusek March 5, 2025 09:24
pyproject.toml Outdated
build-backend = "hatchling.build"

[project]
name = "fingerprint_datapoints"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no mentioning Apify?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, renamed.

@@ -0,0 +1,201 @@
Apache License
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't we use the license from the root dir?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. WIll reuse it.

@Pijukatel Pijukatel added the adhoc Ad-hoc unplanned task added during the sprint. label Mar 6, 2025
@Pijukatel Pijukatel marked this pull request as ready for review March 6, 2025 14:56
Copy link
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK I think, just some questions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How frequently do you think we'll release this? Should we automate changelog generation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be on demand, only when there is reason to. But I do not expect periodic releases. So I would suggest adding automation only if my prediction proves wrong :D

Comment on lines +2 to +3
requires = ["hatchling"]
build-backend = "hatchling.build"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the benefits of using hatch over uv or poetry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I picked the same build-backend we use in crawlee. (Maybe there is better option, but I would rather stick with the same tool in our repos. If we decide to change it, lets do it for all repos.)

Copy link

@vdusek vdusek Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the benefits of using hatch over uv or poetry?

uv does not have its own backend (see astral-sh/uv#3957), and they recommend using hatchling (it's from PyPA).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They do, see the same issue 😏 astral-sh/uv#3957 (comment) or Hynek's recent video https://www.youtube.com/watch?v=mFyE9xgeKcA

Copy link

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pijukatel Pijukatel merged commit 344a7d0 into master Mar 10, 2025
3 of 6 checks passed
@Pijukatel Pijukatel deleted the fingerprint-datapoints-python-package branch March 10, 2025 07:06
@Pijukatel
Copy link
Contributor Author

Failing CI due to unrelated issues: #355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants