Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update project to allow Python3.8 #356

Merged
merged 1 commit into from
Mar 10, 2025
Merged

chore: Update project to allow Python3.8 #356

merged 1 commit into from
Mar 10, 2025

Conversation

Pijukatel
Copy link
Contributor

Fix release notes link in metadata

@Pijukatel
Update project to allow Python3.8
d7490f9 
Fix release notes link in metadata
@Pijukatel Pijukatel added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Mar 10, 2025
@github-actions github-actions bot added this to the 110th sprint - Tooling team milestone Mar 10, 2025
@Pijukatel Pijukatel requested a review from vdusek March 10, 2025 09:04
@Pijukatel Pijukatel marked this pull request as ready for review March 10, 2025 09:05
vdusek
vdusek reviewed Mar 10, 2025
View reviewed changes
Copy link

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Python 3.8?

@Pijukatel
Copy link
Contributor Author

Pijukatel commented Mar 10, 2025 •
edited
Loading

Why Python 3.8?

Because of browserforge

@B4nan
Copy link
Member

B4nan commented Mar 10, 2025

I wouldn't care about that personally.

@Pijukatel
Copy link
Contributor Author

I wouldn't care about that personally.

Poetry would refuse to install this package to browserforge if it does not show support for same python versions as the "main" project

@Pijukatel Pijukatel merged commit bd8c14f into master Mar 10, 2025
3 of 6 checks passed
@Pijukatel Pijukatel deleted the update-python-package-metadata branch March 10, 2025 09:09
@B4nan
Copy link
Member

B4nan commented Mar 10, 2025

Browser forge depends on this package? 👀

@Pijukatel
Copy link
Contributor Author

Browser forge depends on this package? 👀

That is why I am publishing it. See apify/apify-sdk-python#423 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@Pijukatel Pijukatel

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
110th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
3 participants
@Pijukatel @B4nan @vdusek