Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Approve usage of products in key apps #628

Closed
peruzzof opened this issue Jan 22, 2025 · 2 comments · Fixed by #629
Closed

[FR] Approve usage of products in key apps #628

peruzzof opened this issue Jan 22, 2025 · 2 comments · Fixed by #629
Assignees
Labels
enhancement New feature or request

Comments

@peruzzof
Copy link

peruzzof commented Jan 22, 2025

Is your feature request related to a problem? Please describe.
I am automating the renewal of app keys, per design our products are set as "private". This means that whenever I create a new key it is in the "pending" state and there is no existing way to approve it.

Describe the solution you'd like
Implement the new commands:
apigeecli apps keys product approve
apigeecli apps keys product revoke

It must receive the same arguments as the keys get, with the additional list of products to be approved.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
This is the result of the "keys get" command:

{
        "apiProducts": [
                {
                        "apiproduct": "***REDACTED***",
                        "status": "pending"
                }
        ],
        "consumerKey": "***REDACTED***",
        "consumerSecret": "***REDACTED***",
        "expiresAt": "1769081929988",
        "issuedAt": "1737545929988",
        "status": "approved"
}

The method to be used is https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.developers.apps.keys.apiproducts/updateDeveloperAppKeyApiProduct

@srinandan srinandan self-assigned this Jan 22, 2025
@srinandan srinandan added the enhancement New feature or request label Jan 22, 2025
@srinandan srinandan linked a pull request Jan 22, 2025 that will close this issue
@srinandan
Copy link
Collaborator

The proposed change is:

apigeecli apps keys manage --help                                                                         
Approve or revoke a developer app key

Usage:
  apigeecli apps keys manage [flags]

Flags:
  -x, --action string    Action to perform - revoke or approve (default "revoke")
  -h, --help             help for manage
  -k, --key string       Developer app consumer key
      --product string   Name of the API Product; If not set the action is performed on all the API Products

--product is optional. If set then the command applies to the product. If not set, then it applies to all products.

@ssvaidyanathan
Copy link
Collaborator

Fixed in v2.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants