[BUG] Service Endpoint creationg fails with Disk Encryption error

[nishantnasa]

Describe the bug
When creating a service endpiont using apigeecli it fails with disk encryption error and the same request works fine using apigee api curl command

The command in question:

apigeecli endpoints create \
  --org "{ord}" \
 --token $TOKEN  \
--name test-psc-endpoint \
--location australia-souteast1 \
-s "projects/PROJECT_ID/regions/australia-southeast1/serviceAttachments/SA_NAME"

Error: disk encryption key must be of the format projects/{project-id}/regions/{location}/serviceAttachments/{sa-name}

The following curl command works fine and successfuly creates the endpoint attachment for PSC consumer:

curl -X POST -H "Authorization: Bearer $TOKEN" -H "Content-Type:application/json" \
"https://apigee.googleapis.com/v1/organizations/ORGANIZATION/endpointAttachments?endpointAttachmentId=EA_NAME" \
-d '{
    "location": "australia-southeast1",
    "serviceAttachment": "projects/PROJECT_ID/regions/australia-southeast1/serviceAttachments/SA_NAME"
}'

Version
apigeecli version 2.9.0 date: 2025-01-22T22:34:55Z [commit: 4d20467]

To Reproduce
Create a PSC Service Attachment in Producer project first and use the corresponding service attachment details in the following command to create the apigeex endpoint attachment for the PSC consumer

apigeecli endpoints create \
  --org "{ord}" \
 --token $TOKEN  \
--name test-psc-endpoint \
--location australia-souteast1 \
 --region australia-southeast1 \
-s "projects/PROJECT_ID/regions/australia-southeast1/serviceAttachments/SA_NAME"

Expected behavior
Endpoint attachment should be created successfully without any errors within ApigeeX

Additional context

[kurtkanaskie]

Thanks for creating this bug, I was able to verify and determine the root cause:

In the lines below is using the wrong parameter location

		ok := re.Match([]byte(location))
		if !ok {
			return fmt.Errorf("disk encryption key must be of the format " +
				"projects/{project-id}/regions/{location}/serviceAttachments/{sa-name}")
		}

It should be serviceAttachment:

                 ok := re.Match([]byte(serviceAttachment))
		if !ok {
			return fmt.Errorf("serviceAttachment must be of the format " +
				"projects/{project-id}/regions/{location}/serviceAttachments/{sa-name}")
		}

[ssvaidyanathan]

@nishantnasa - fixed and released in v2.9.1