New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enclose bash argument values in quotes to allow spaces #1097

Merged

designatednerd merged 1 commit into apollographql:master from sfoulston:fix/spaces-in-codegen-bash-paths

Mar 30, 2020

Contributor

sfoulston commented Mar 25, 2020

Following on from #1092 – I found a few more places where enclosing bash argument values in quotes is advisable.


          Enclose bash argument values in quotes to allow spaces

10b76d6

designatednerd reviewed

View reviewed changes

Contributor

designatednerd left a comment

code looks good, rerunning flaky test

designatednerd merged commit ad8af44 into apollographql:master

designatednerd added this to the Next Release milestone

sfoulston deleted the fix/spaces-in-codegen-bash-paths branch

April 18, 2020 13:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet