Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apollo custom extension to replace apollo_ prefix #1182

Closed
wants to merge 6 commits into from
Closed

Add apollo custom extension to replace apollo_ prefix #1182

wants to merge 6 commits into from

Conversation

yuzushioh
Copy link
Contributor

@yuzushioh yuzushioh commented May 2, 2020 •
edited
Loading

Added ApolloExtension and replace apollo_ prefix by apollo. ref: #1170

@apollo-cla
Copy link

@yuzushioh: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@designatednerd
Copy link
Contributor

Looks like you'll need to update the code generation script in SwiftScripts to get this to compile:

Screen Shot 2020-05-02 at 11 25 52 AM

@yuzushioh
Copy link
Contributor Author

@designatednerd I think its fixed now

@yuzushioh
Copy link
Contributor Author

yuzushioh commented May 2, 2020 •
edited
Loading

Ok it's not fixed. I will check it tomorrow. Looks like ApolloCodegenLib build in SwiftScripts is not updated.

designatednerd
designatednerd reviewed May 2, 2020
View reviewed changes
Sources/ApolloCodegenLib/ApolloExtension.swift Outdated
public let base: Base
}

protocol ApolloCompatible {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this needs to be public protocol ApolloCompatible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it. Some of CI tests are still failing but Im not sure why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait Swift Code Generation failure is my fault.

@yuzushioh
Copy link
Contributor Author

I will re-submit the PR after I fix the test

@yuzushioh yuzushioh closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@designatednerd designatednerd designatednerd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuzushioh @apollo-cla @designatednerd