Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift Codegen: Input Objects + Updated Types #1194

Merged
merged 24 commits into from
May 7, 2020
Merged

Swift Codegen: Input Objects + Updated Types #1194

merged 24 commits into from
May 7, 2020

Conversation

designatednerd
Copy link
Contributor

@designatednerd designatednerd commented May 6, 2020 •
edited
Loading

In This PR:

  • Switches ASTForthcomingVariableType to be the final version, ASTVariableType.
  • Updates existing code for changes to the JSON format
  • Adds a new ApolloCore library for types that need to be shared between the main lib and the codegen lib
  • Adds a GraphQLOptional type to the core library and uses it within the updated code generation
  • Actually generates code for input objects
  • Adds documentation to initializer structs

This was referenced May 6, 2020
Closed
Closed
@designatednerd
Add GraphQL optional for input objects
cc30705
@designatednerd
Make a few things public, use dict keys to *slightly* reduce stringly…
cb7d54f 
…-typed code
@designatednerd
add input object generator and expected files
7a08813
@designatednerd
Add test for generating object with no optionals
1b57efe
@designatednerd
validate alignment works with no modifier
5a7ee36
@designatednerd
use json-modern to also output types
fd22849
@designatednerd
WIP change to get Star wars to output json
bb8b568
@designatednerd
update to API.json from running json-modern
22f3a81
@designatednerd
Update tests and variable type for updated JSON parsing
ea5d14e
@designatednerd
Update test to use json-modern
5c5ab66
@designatednerd
update name of test to be accurate 🤦‍♀️
35be5f0
@designatednerd
make GraphQLOptional conform to Hashable
0c26abf
@designatednerd
add methods to tell if a type is optional and generate a GraphQLOptio…
700dc42 
…nal for it
@designatednerd
Get first input object generator test passing \o/
5b1e878
@designatednerd
add test for input object generated without modifier
d2f87b3
@designatednerd
Add initializer doc generation for input objects - addresses #562
c7168df
@designatednerd
turn on thread sanitizer for the codegen lib target
b19176a
@designatednerd
Set the error and signal the semaphore from the same place to make su…
d679517 
…re there's not a race condition
@designatednerd
Take out temporary codegen options
8daa632
@designatednerd designatednerd marked this pull request as ready for review May 6, 2020 23:03
@designatednerd
Copy link
Contributor Author

(Note that a huge chunk of the changeset here is changes to API.json caused by updates to the CLI)

@designatednerd designatednerd mentioned this pull request May 6, 2020
Closed
@designatednerd designatednerd merged commit 09d963f into master May 7, 2020
@designatednerd designatednerd deleted the add/input-objects branch May 7, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@designatednerd