Update how requests are created so custom subclasses of HTTP requests can be used #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of custom subclasses of `HTTPRequest`.
…lace that acutally uses it and it can now be subclassed.
designatednerd
commented
Sep 21, 2020
| import XCTest | ||
| import Apollo | ||
|
|
||
| class MultipartFormDataTests: XCTestCase { |
There was a problem hiding this comment.
Moved this out of the request creator tests to disambiguate what's actually being tested here
designatednerd
commented
Sep 21, 2020
| @@ -27,40 +27,4 @@ struct TestCustomRequestCreator: RequestCreator { | |||
|
|
|||
| return body | |||
| } | |||
|
|
|||
| public func requestMultipartFormData<Operation: GraphQLOperation>(for operation: Operation, | |||
There was a problem hiding this comment.
This is no longer a requirement of the RequestBodyCreator protocol, so it's been removed
designatednerd
commented
Sep 21, 2020
| @@ -198,6 +199,225 @@ class UploadTests: XCTestCase { | |||
| } | |||
|
|
|||
| self.wait(for: [expectation], timeout: 10) | |||
| } | |||
|
|
|||
| // MARK: - UploadRequest | |||
There was a problem hiding this comment.
These tests were moved over from the RequestCreator tests since they no longer have anything to do with the request creator
designatednerd
changed the title
|
These are slightly larger changes than I'd normally like to make at the RC stage, but I've been itching to get rid of the request creator and this gave me an opening to get rid of its most convoluted bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
RequestChainNetworkTransportsubclassable and changed two methods to be open so they can be subclassed in order to facilitate using subclasses ofHTTPRequestwhen needed. (thanks for the suggestion, Networking Beta: Convenience constructors for HTTPRequest and JSONRequest #1404)UploadRequest, which meant:UploadRequestis nowopenso it can be subclassed.UploadRequestinstead ofRequestCreator, and non-default creation should be moved from an implementation ofRequestCreatorto a subclass ofUploadRequest.RequestCreatorprotocol has now been renamedRequestBodyCreator, since it only creates the request body and not a fullHTTPRequest(which didn't exist in the old networking stack, so the name made more sense then). Associated implementations and property names have been changed accordingly.RequestBodyCreatorprotocol.