Remove setter from Atomic to prevent API misuse, fix TSAN error in network interceptor
#1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
designatednerd
force-pushed
the
update/atomic-setup
branch
from
f5d01a4 to
b74d811
Compare
martijnwalraven
approved these changes
Nov 25, 2020
| } | ||
|
|
||
| public func cancel() { | ||
| self.currentTask?.cancel() | ||
| guard let task = self.currentTask.value else { |
There was a problem hiding this comment.
It seems this could just be self.currentTask.value?.cancel(), but I assume you prefer this because you find it more readable?
There was a problem hiding this comment.
somewhat, yep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martijnwalraven pointed out in #1531 that it's a little too easy to accidentally misuse the
AtomicAPI as it stands now, particularly in terms of dealing with things like toggling a boolean or making changes to an array. This PR removes the setter wrapper forvalue, so that if you need to make changes, you can only change things by usingmutate, which executes the changes in a block for safety.I also fixed a thread sanitizer error in the Network interceptor around the
cancellablethat it holds onto. Once this and #1531 are merged, that should allow us to turn on thread sanitizer in tests permanently. 🤞