Fix encoding of + in parameters for GET urls #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,6 +43,8 @@ public struct GraphQLGETTransformer { | |||
| } | |||
|
|
|||
| components.queryItems = queryItems | |||
| components.percentEncodedQuery = | |||
| components.percentEncodedQuery?.replacingOccurrences(of: "+", with: "%2B") | |||
There was a problem hiding this comment.
I wonder if this needs to actually be replaced in the query items rather than in the percent encoded query for it to essentially get re-percent-encoded so it's not read by the server as a raw string.
…y to the encoded query" This reverts commit f69f32b.
designatednerd
force-pushed
the
fix-plus-sign-url-encoding
branch
from
0fe7c9d to
e60e793
Compare
|
Ran this through a couple different URL decoders and discovered that @AnthonyMDev's fix is the correct one - my fix would get decoded as |
|
Since this is passing URL decoders, I'm going to go ahead and merge this. I'll re-open #1652 if merging this auto-closes since we're still waiting for a bit of feedback on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1652