Make initializer for ApolloSchemaDownloadConfiguration.HTTPHeader public #1962
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import XCTest | ||
| import ApolloTestSupport | ||
| import ApolloCodegenTestSupport | ||
| @testable import ApolloCodegenLib | ||
|
|
||
| class ApolloSchemaInternalTests: XCTestCase { | ||
| func testFormatConversion_givenIntrospectionJSON_shouldOutputValidSDL() throws { | ||
| let bundle = Bundle(for: type(of: self)) | ||
| guard let jsonURL = bundle.url(forResource: "introspection_response", withExtension: "json") else { | ||
| throw XCTFailure("Missing resource file!", file: #file, line: #line) | ||
| } | ||
|
|
||
| try FileManager.default.apollo.createFolderIfNeeded(at: CodegenTestHelper.outputFolderURL()) | ||
| let configuration = ApolloSchemaDownloadConfiguration(using: .introspection(endpointURL: TestURL.mockPort8080.url), | ||
| outputFolderURL: CodegenTestHelper.outputFolderURL()) | ||
|
|
||
| try ApolloSchemaDownloader.convertFromIntrospectionJSONToSDLFile(jsonFileURL: jsonURL, configuration: configuration) | ||
| XCTAssertTrue(FileManager.default.apollo.fileExists(at: configuration.outputURL)) | ||
|
|
||
| let frontend = try ApolloCodegenFrontend() | ||
| let source = try frontend.makeSource(from: configuration.outputURL) | ||
| let schema = try frontend.loadSchemaFromSDL(source) | ||
|
|
||
| let authorType = try schema.getType(named: "Author") | ||
| XCTAssertEqual(authorType?.name, "Author") | ||
|
|
||
| let postType = try schema.getType(named: "Post") | ||
| XCTAssertEqual(postType?.name, "Post") | ||
| } | ||
| } | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reason to keep these private; once you've created the struct you should be able to inspect the property values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True for as long as they remain
lets - If they'revars we may or may not want to allow direct access, although we could handle that with aprivate(set).