Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape Reserved Keywords in Codegen [1/X] #2432

Merged
merged 11 commits into from
Aug 12, 2022

Conversation

AnthonyMDev
Copy link
Contributor

@AnthonyMDev AnthonyMDev commented Aug 12, 2022

This PR addresses the primary issue encountered in #2424. There is more work to be done on other types that surfaced during researching this bug.

This PR:

  • Escapes swift reserved keywords in Field Accessors names
  • Escapes swift reserved keywords in Test Mock property names
  • Disallows certain field names entirely and Validate them in frontend
  • Fixes automatic uppercasing of type names to uppercase the first actual letter.
    • for eg. on fields named _test or 5thElement
  • Adds _SelectionSet suffix to generated selection set names that conflict

@netlify
Copy link

netlify bot commented Aug 12, 2022

Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit 352d963
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/62f5b76614ec9e00081bc7be

@netlify
Copy link

netlify bot commented Aug 12, 2022

Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 352d963
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/62f5b766bcd97e0009fb5f6a

@AnthonyMDev AnthonyMDev merged commit ac7690b into release/1.0 Aug 12, 2022
@AnthonyMDev AnthonyMDev deleted the escape-keywords-codegen branch August 12, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant