update: Raise minimum Swift tools version to 5.7
#2695
Conversation
✅ Deploy Preview for apollo-ios-docs canceled.
|
| @@ -16,7 +16,7 @@ struct SwiftPackageManagerModuleTemplate: TemplateRenderer { | |||
| let casedSchemaName = config.schemaName.firstUppercased | |||
|
|
|||
| return TemplateString(""" | |||
| // swift-tools-version:5.6 | |||
| // swift-tools-version:5.7 | |||
There was a problem hiding this comment.
There's nothing in ApolloAPI at the moment that would warrant this but there is no reason we couldn't use those new Swift features there.
|
hmm. This doesn't feel like it should've been part of a patch release IMO. Just got the error that I can no longer build with it...just as an fyi |
|
That's a fair point @corymosiman12, thanks for the feedback. It was viewed as a patch release because the current state, at the time, was broken builds on older versions of Xcode. Had this been a minor version release the situation then would have still been to stay on a broken patch release or migrate to the next minor bump. |
|
In retrospect we maybe should have left the generated package on |
|
all good, I'm no pro at this either, just wanted to relay my feedback |
Closes #2688
Apollo iOS contains code that will only build with Swift
5.7, such as the newif letshorthand from SE-0435. It's not a great experience to have the project load only to result a build error if you're using a version of Xcode that doesn't support Swift5.7; <14.0.This PR simply raises the required version of Swift to build the project making the user aware earlier of their tool versioning mismatch.