fix: Use correct schema namespace casing in fragments #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
AnthonyMDev
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2705
FragmentTemplatewas a template still using schema name from the IR schema. It now uses schema name from the codegen configuration.I thought we'd caught all these places in #2586 but it turns out not. So I've now removed schema name from
IR.Schemaso it cannot be had from there anymore and I've removed the IR schema from templates and file generators where it's not used.I'd prefer to have a centralized place where
config.schemaNameis first capitalized without having to do it in many different places but I'll handle that in the next round of config changes.