-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ScalarType casting for Int values #3037
Conversation
`Int32` and `Int64` values were failing to cast to `ScalarType` because only `Int` conformed to `ScalarType`, adding conformance to both `Int32` and `Int64` to solve this
✅ Deploy Preview for apollo-ios-docs canceled.
|
Going to refactor this to make sure we are always working with |
Updating casting to happen in subscript methods of `ObjectData` and `ListData`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks @BobaFetters. My only nitpick is updating the PR description to accurately reflect the diff.
@BobaFetters - I was thinking this morning that none of the execution sources perform JSON deserialization. We should probably add another test that actually uses |
@calvincestari What kind of test are you thinking? One that checks that |
It wouldn't be about checking for an |
Int32
andInt64
values were failing to cast toScalarType
because onlyInt
conformed toScalarType
, adding code to thesubscript
functions ofObjectData
andListData
to handle castingAnyHashable
representations ofInt32
andInt64
to justInt
before the attempted casting toScalarType
Closes #3034