Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operation Manifest Generation Updates #3128

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Operation Manifest Generation Updates #3128

merged 3 commits into from
Jul 19, 2023

Conversation

BobaFetters
Copy link
Member

  • Updated the Operation Manifest generation to be able to do either an absolute path as provided (which is the current functionality) or to take relative paths that begin with './' and have the pathing be relative to the config rootURL
    -Updated tests to reflect these changes

@BobaFetters
Operation Manifest Generation Updates
c91e2fb 
- Updated the Operation Manifest generation to be able to do either an absolute path as provided (which is the current functionality) or to take relative paths that begin with './' and have the pathing be relative to the config rootURL
-Updated tests to reflect these changes
@BobaFetters BobaFetters self-assigned this Jul 19, 2023
@netlify
Copy link

netlify bot commented Jul 19, 2023 •
edited
Loading

✅ Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit 5b5b678
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/64b84a560866af0008cc6495

calvincestari
calvincestari approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question on whether we care to check for an existing file extension.

AnthonyMDev
AnthonyMDev approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just want to make sure we add tests for the .json.json issue and this is good to go!

AnthonyMDev
AnthonyMDev approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you LGTM!

@BobaFetters BobaFetters merged commit 7515d46 into main Jul 19, 2023
@BobaFetters BobaFetters deleted the feature/persisted-queries-manifest branch July 19, 2023 20:55
AnthonyMDev pushed a commit that referenced this pull request Aug 2, 2023
@BobaFetters @AnthonyMDev
Operation Manifest Generation Updates (#3128)
0df9af0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvincestari calvincestari calvincestari approved these changes

@AnthonyMDev AnthonyMDev AnthonyMDev approved these changes

Assignees

@BobaFetters BobaFetters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BobaFetters @calvincestari @AnthonyMDev