Fix Apollo Build Step script because it fails when Schemes have space in their names #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in their names When there is spaces in any path of the FRAMEWORK_SEARCH_PATHS, the `find` command fails. Having a scheme with a space in its name will cause FRAMEWORK_SEARCH_PATHS to have spaces in each path. This edit changes the `find` separation character to `\n` from ` ` through `IFS` and fixes the FRAMEWORK_SEARCH_PATHS to include double quotes on its first path (which is without double quotes even if it has a space in the path). Not adding the double quotes also breaks `find` when it reads a path with a space if `IFS` is set
|
@Valpertui: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
ghost
added
blocking
|
It's also a fix for this issue #225 |
|
Would be good to get this merged, @Valpertui thanks for making it, can you sign the agreement so the Apollo team can merge it? |
|
@ricsantos I did sign it back in october, but I signed it again today. |
This was referenced Jul 2, 2019
|
I'm going to close this one out in favor of #610 - there was some stuff that also needed to be fixed in the docs and with CocoaPods, but your work on that command to get everything working fine with spaces in project and scheme names was super-helpful with that. Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is spaces in any path of the FRAMEWORK_SEARCH_PATHS, the
findcommand fails.Having a scheme with a space in its name will cause FRAMEWORK_SEARCH_PATHS to have spaces in each path.
This edit changes the
findseparation character to\nfromIFSand fixes the FRAMEWORK_SEARCH_PATHS to include double quotes on its first path (which is without double quotes even if it has a space in the path). Not adding the double quotes also breaksfindwhen it reads a path with a space ifIFSis set