export createRequest method for extending the transport #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make even the most trivial adjustment to the request, like being able to dynamically specify the headers, you have to copy the full implementation of the transport class. By exposing the `createRequest` method, this would be possible by simply extending the existing transport, and only override the `createRequest` method.
ghost
added
the
|
Hey @koenpunt - Thank you for doing this, and sorry for the long radio silence on our end! Unfortunately since so much has changed since this PR was opened, I'm going to close this in favor of the work happening in #602 to implement this feature. Please feel free to chime in there if you have thoughts or questions, and open issues on anything you feel we may be leaving out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make even the most trivial adjustment to the request, like being able to dynamically specify the headers, you have to copy the full implementation of the transport class.
By exposing the
createRequestmethod, this would be possible by simply extending the existing transport, and only override thecreateRequestmethod.