Add LinkedHashMap type support to RecordFieldJsonAdapter #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sav007
reviewed
Jul 25, 2018
| @@ -84,6 +85,15 @@ private static void writeJsonValue(Object value, JsonWriter jsonWriter) throws I | |||
| writeJsonValue(item, jsonWriter); | |||
| } | |||
| jsonWriter.endArray(); | |||
| } else if (value instanceof LinkedHashMap) { | |||
There was a problem hiding this comment.
I think we should use more generic type Map instead as we can easily change internal logic and use other implementation of Map in future.
This was referenced Jul 27, 2018
sav007
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #1001
RecordFieldJsonAdapter does not support LinkedHashMap at the moment, so it's unable to parse json objects if no custom types are defined. This bug is blocking SqlNormalisedCache from persisting these objects to the database.