Update codegen to work for AbcCTum (Was converting to AbcCtum) #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key is AbcCTA, which get's converted by singularize to structName: AbcCTum (this is already not great, but not the bug causing compilation issues) The key is used to create the structName. In this place the property (abcCtum) was being used instead which made: AbcCtum (AbcCTum and AbcCtum don't match, notice the T vs t)
|
@cltnschlosser Yeah there's some real messy stuff in here around pluralization but it should at least compile. Would you mind adding a test for this so we don't accidentally break it in the future? |
|
Yeah, I can try. |
|
Well this test isn't perfect, but it breaks if you revert my change. |
designatednerd
approved these changes
Dec 2, 2020
|
I'll ping the team tomorrow about getting a release out with this but the test is helpful. For what it's worth this won't be a problem in the new codegen because you'll be able to specify pluralizations if things aren't coming out the way you want from the default singularizer/pluralizer. Here's the pull where I've set that up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key is AbcCTA, which get's converted by singularize to structName: AbcCTum (this is already not great, but not the bug causing compilation issues)
The key is used to create the structName.
In this place the property (abcCtum) was being used instead which made: AbcCtum (AbcCTum and AbcCtum don't match, notice the T vs t)
CC @designatednerd