Revert "Add DocumentNode to gql declaration (#196)"

[jnwng]

This reverts commit ae792b6. Based on #196 and #150, introducing the DocumentNode return value causes this library to break for existing TypeScript installations. I'm reverting this temporarily so we can release support for GraphQL v14 in a minor patch, and if we can't fix the TypeScript configuration, we'll release a major version with this commit back in.

/cc @felixfbecker @kamilkisiela since i still can't figure out how to fix the TypeScript installation in a non-breaking way.

[felixfbecker]

In #150 I suggested to reexport the DocumentNode interface. I still believe that would prevent the error

[kamilkisiela]

@jnwng I still don't think it's true what you said. TypeScript doesn't break anything if DocumentNode is correctly defined as a return value of a function.

In latests versions of TS it transforms each imported interface to something like this if they were implicit:

export default function gql(literals: any, ...placeholders: any[]): import('graphql/something/document-node').DocumentNode;

But we explicitly import DocumentNode and define it as a return type.

[kamilkisiela]

@kamilkisiela/[email protected] is my copy of [email protected] with DocumentNode included

[felixfbecker]

Frankly it baffles me that this same change was merged twice and reverted twice, instead of trying the fix I suggested.

[kamilkisiela]

@jnwng @felixfbecker I would say, let's release it as a RC, make people check it and release a stable one. People scream about a lot of things but usually they use TypeScript incorrectly or doesn't understand it at all and half of the time it's their internal setup that's causing an issue.

[jnwng]

i’m really not that familiar with typescript so i’m only responding to issues that folks are filing - i think i just needed a PR from someone who is sure about their setup, and ideally a test to verify the behavior. @kamilkasiela great idea about releasing an RC, i’ll take your changes and do just that since it sounds like you’re happy with the DocumentNode export!

…

On Tue, Oct 2, 2018 at 12:35 AM Kamil Kisiela ***@***.***> wrote: @jnwng <https://github.com/jnwng> @felixfbecker <https://github.com/felixfbecker> I would say, let's release it as a RC, make people check it and release a stable one. People scream about a lot of things but usually they use TypeScript incorrectly or doesn't understand it at all and half of the time it's their internal setup that's causing an issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#218 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABERRj5Mw6ICAWbMRrh5VLh_H351NdBFks5ugxckgaJpZM4XDWxG> .