This repository was archived by the owner on Aug 14, 2020. It is now read-only.
spec: move labels matching part to discovery. #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
changed the title
sgotti
force-pushed
the
spec_move_labels_matching_to_discovery
branch
from
51732c7 to
25502fe
Compare
Now aci.md "Dependency Matching" chapter explains how dependency's name and labels are used for discovery and then compared to the name and labels in the Image Manifest of the retrieved image. This labels matching should be done for every discovery. This patch moves the labels matching part to discovery, and keeps in "Dependency Matching" the additional ImageID check. From the logical point of view of "Dependency Matching" this means that now labels matching is done before ImageID matching since it's included in the discovery logic.
sgotti
force-pushed
the
spec_move_labels_matching_to_discovery
branch
from
25502fe to
c8d6e92
Compare
|
LGTM.. @vbatts? |
|
lgtm |
philips
added a commit
that referenced
this pull request
Aug 6, 2015
…overy spec: move labels matching part to discovery.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now aci.md "Dependency Matching" chapter explains how dependency's name and
labels are used for discovery and then compared to the name and labels in the
Image Manifest of the retrieved image.
This labels matching should be done for every discovery.
This patch moves the labels matching part to discovery, and keeps in "Dependency
Matching" the additional ImageID check.
From the logical point of view of "Dependency Matching" this means that now labels
matching is done before ImageID matching since it's included in the discovery
logic.