feat: extend mobile: setGeoLocation #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/commands/geolocation.js
Outdated
| * @param {number} latitude Valid latitude value. | ||
| * @param {number} longitude Valid longitude value. | ||
| * @param {number} [altitude] Valid altitude value. | ||
| * @param {number} [satellites] Number of satellites being tracked (1-12). |
There was a problem hiding this comment.
we should also mention which params are only applicable for emulators and which for real devices
lib/commands/geolocation.js
Outdated
| */ | ||
| export async function mobileSetGeolocation(latitude, longitude, altitude) { | ||
| export async function mobileSetGeolocation(latitude, longitude, altitude, satellites, speed, bearing, accuracy) { |
There was a problem hiding this comment.
it probably makes sense to put line breaks between each arg to make the long list better readable
mykola-mokhnach
approved these changes
Feb 25, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
## [10.2.0](v10.1.2...v10.2.0) (2025-02-25) ### Features * extend mobile: setGeoLocation ([#986](#986)) ([c1c6f67](c1c6f67))
|
🎉 This PR is included in version 10.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ad'satellites', 'speed', 'bearing', 'accuracy' for the mobile command.
Validation will be done in the
this.settingsApp.setGeoLocation