-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend mobile: setGeoLocation #986
Conversation
lib/commands/geolocation.js
Outdated
* @param {number} latitude Valid latitude value. | ||
* @param {number} longitude Valid longitude value. | ||
* @param {number} [altitude] Valid altitude value. | ||
* @param {number} [satellites] Number of satellites being tracked (1-12). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also mention which params are only applicable for emulators and which for real devices
lib/commands/geolocation.js
Outdated
*/ | ||
export async function mobileSetGeolocation(latitude, longitude, altitude) { | ||
export async function mobileSetGeolocation(latitude, longitude, altitude, satellites, speed, bearing, accuracy) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it probably makes sense to put line breaks between each arg to make the long list better readable
## [10.2.0](v10.1.2...v10.2.0) (2025-02-25) ### Features * extend mobile: setGeoLocation ([#986](#986)) ([c1c6f67](c1c6f67))
🎉 This PR is included in version 10.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ad'satellites', 'speed', 'bearing', 'accuracy' for the mobile command.
Validation will be done in the
this.settingsApp.setGeoLocation