fix: start session should return caps that chromedriver returns #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
commented
Nov 10, 2023
| JSON.stringify(sessionCaps, null, 2) | ||
| JSON.stringify(sessionCaps, null, 2), | ||
| ); | ||
| const {capabilities} = /** @type {NewSessionResponse} */ ( |
There was a problem hiding this comment.
sorry, looks like there were some auto lint changes. this is the main change to review here.
KazuCocoa
approved these changes
Nov 10, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
## [5.6.24](v5.6.23...v5.6.24) (2023-11-10) ### Bug Fixes * start session should return caps that chromedriver returns ([#362](#362)) ([499f65e](499f65e))
|
🎉 This PR is included in version 5.6.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support webdriver BiDi, we need to actually return caps that chromedriver returns, since it contains the webSocketUrl value which we may not be able to predict.