fix: respect executableDir even non-adb environment such as desktop #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
changed the title
KazuCocoa
changed the title
jlipps
approved these changes
Mar 8, 2024
mykola-mokhnach
approved these changes
Mar 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
## [5.6.38](v5.6.37...v5.6.38) (2024-03-08) ### Bug Fixes * respect executableDir even non-adb environment such as desktop ([#383](#383)) ([0a3e80e](0a3e80e))
|
🎉 This PR is included in version 5.6.38 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executableDir is given, it would be nice to respect executableDir rather than forcefully use system's one for non-adb env such as desktop.
Current implementation does not respect given
executableDirfor non-adb environment. It means automatic detection/download does not work bygetCompatibleChromedriver.