Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PEMDocument Hashable and Sendable #28

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Make PEMDocument Hashable and Sendable #28

merged 2 commits into from
Apr 21, 2023

Conversation

dnadoba
Copy link
Member

@dnadoba dnadoba commented Apr 20, 2023

No description provided.

@dnadoba dnadoba added the 🆕 semver/minor Adds new public API. label Apr 20, 2023
@dnadoba dnadoba requested a review from Lukasa April 20, 2023 16:33
Lukasa
Lukasa requested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, wanna add Sendable too?

@dnadoba
Copy link
Member Author

dnadoba commented Apr 20, 2023

Good idea, added.

@dnadoba dnadoba requested a review from Lukasa April 21, 2023 09:02
@Lukasa Lukasa merged commit c43fef6 into main Apr 21, 2023
@Lukasa Lukasa deleted the dn-pem-document-hashable branch April 21, 2023 09:36
@Lukasa Lukasa changed the title Make PEMDocument Hashable Make PEMDocument Hashable and Sendable Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnadoba @Lukasa