Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support macOS 10.14.x/iOS 12.x and older again #34

Merged
merged 4 commits into from
Jul 3, 2023
Merged

Support macOS 10.14.x/iOS 12.x and older again #34

merged 4 commits into from
Jul 3, 2023

Conversation

dnadoba
Copy link
Member

@dnadoba dnadoba commented Jun 30, 2023 •
edited
Loading

Motivation

#32 has broken older platforms accidentally.

Modifications

  • add availability annotations to DER.lazySet
  • copy over the implementation of DER.lazySet to DER.set
  • add tests specifically covering DER.lazySet because we can no longer use DER.lazySet in the implementation of DER.set and therefore DER.lazySet would be completely untested.

Result

We again support macOS 10.14.x/iOS 12.x and older.

@dnadoba dnadoba added the 🔨 semver/patch No public API change. label Jun 30, 2023
Lukasa
Lukasa requested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than do that, let's just use a wrapper type instead of the opaque result type.

@dnadoba
Copy link
Member Author

dnadoba commented Jun 30, 2023

Good idea, done in 29d2be9

Lukasa
Lukasa approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Lukasa Lukasa merged commit 4758353 into main Jul 3, 2023
@Lukasa Lukasa deleted the dn-fix-older-platforms branch July 3, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnadoba @Lukasa