build: simplify the build rules (NFC) #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift requires CMake 3.19.x to build. Update the minimum supported CMake to allow us to simplify the build rules somewhat by removing the workarounds for older releases. Additionally, re-order and use straightline configuration over conditional paths.
|
@swift-server-bot please test |
yim-lee
approved these changes
Nov 28, 2023
etcwilde
reviewed
Nov 28, 2023
|
|
||
| if(NOT CMAKE_SYSTEM_NAME STREQUAL Darwin) |
There was a problem hiding this comment.
We are we removing the Darwin check? I could see a module package search working on Darwin.
There was a problem hiding this comment.
It doesn't need to be isolated, it is with a CONFIG variant, so it is meant for the build output. All this does is prevent 2 lines from being printed on Darwin, it has no negative consequences.
|
@yim-lee can we merge this? I have a follow up change that I would like to put up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift requires CMake 3.19.x to build. Update the minimum supported CMake to allow us to simplify the build rules somewhat by removing the workarounds for older releases. Additionally, re-order and use straightline configuration over conditional paths.