Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python modules improvements #1572

Merged
merged 8 commits into from
Aug 3, 2017

Conversation

glebmish
Copy link
Contributor

@glebmish glebmish commented Aug 2, 2017

Refactored of appleseed.python/CMakeLists.txt to update build process of Python bindings
Added Qt.py - library that wraps different Qt Python binding (PyQt, PySide and so on) and provides unified interface for them

Copy link
Member

@est77 est77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving our python packaging cmake macros.
I'd prefer not to add the extra appleseed directory inside appleseed.python.
Other than that, I have some small comments and it'd good to merge for me.

@@ -167,10 +167,5 @@ PythonInterpreter::PythonInterpreter()
{
}

PythonInterpreter::~PythonInterpreter()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave the destructor, comment Py_Finalize() and add a comment to explain why we don't call it?

@@ -27,3 +27,4 @@
#

from _appleseedstudio import *
import Qt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this line. Using any python Qt binding should be optional and if the user does not have one,
we should not error.

@glebmish glebmish force-pushed the python-modules-improvements branch from b6771c5 to 66fe751 Compare August 3, 2017 17:37
@est77 est77 merged commit 5365b7c into appleseedhq:master Aug 3, 2017
@glebmish glebmish deleted the python-modules-improvements branch August 3, 2017 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants