Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async retrieval function #108

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Add async retrieval function #108

merged 1 commit into from
Nov 16, 2022

Conversation

hannahhoward
Copy link
Contributor

Adds a function that runs retrieval asynchronously, allowing a user to request a graceful shutdown

@hannahhoward hannahhoward force-pushed the async-retrieve branch 2 times, most recently from ee16d04 to 17c646c Compare November 16, 2022 01:54
@hannahhoward
feat(filclient): add async retrieval function
6717b9e 
Adds a function that runs retrieval asynchronously, allowing a user to
request a graceful shutdown
@rvagg rvagg marked this pull request as ready for review November 16, 2022 05:52
rvagg
rvagg approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, lgtm
I probably would have been more heavy-handed with this and made a whole new type to return as a handle that had these things hanging off it, but this works too and is more lightweight!

@hannahhoward hannahhoward merged commit 9fc1b8b into master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahhoward @rvagg