[gas] permission

[lightmark]

Description

add Gas permission

[trunk-io]

⏱️ 27m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-move-unit-coverage	12m	🟩
rust-move-tests	10m	🟥
rust-cargo-deny	2m	🟩
check-dynamic-deps	2m	🟩
general-lints	29s	🟩
semgrep/ci	22s	🟩
file_change_determinator	9s	🟩
permission-check	7s	🟩
permission-check	2s	🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.1%. Comparing base (e4239a8) to head (adeff45).

Additional details and impacted files

@@                       Coverage Diff                        @@
##           09-11-permission_for_framework   #15232    +/-   ##
================================================================
  Coverage                            60.0%    60.1%            
================================================================
  Files                                 857      857            
  Lines                              210762   210762            
================================================================
+ Hits                               126586   126726   +140     
+ Misses                              84176    84036   -140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[runtian-zhou]

Who will pass the gas_payer sender to the prologue? Or in other words, when can the gas_payer be the permissioned signer?

[runtian-zhou]

Just double checked the code. The fee payer can be a permissioned signer when running an AA in aptos_vm. Looks good to me now.

[igor-aptos]

yes, and if transient signer is used - it's a master signer here, so permission is not used - the max_gas from transaction that user explicitly signed serves that purpose

[github-actions]

✅ Forge suite compat success on 17540fad8e88ab5681f3a91190b9f5d37e53d2ef ==> f5b8dc613065c4a14ca3d5cc8ae4f880ecd53dc9

Compatibility test results for 17540fad8e88ab5681f3a91190b9f5d37e53d2ef ==> f5b8dc613065c4a14ca3d5cc8ae4f880ecd53dc9 (PR)
1. Check liveness of validators at old version: 17540fad8e88ab5681f3a91190b9f5d37e53d2ef
compatibility::simple-validator-upgrade::liveness-check : committed: 14342.18 txn/s, latency: 2186.39 ms, (p50: 2100 ms, p70: 2300, p90: 2900 ms, p99: 4200 ms), latency samples: 472560
2. Upgrading first Validator to new version: f5b8dc613065c4a14ca3d5cc8ae4f880ecd53dc9
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3974.73 txn/s, latency: 7720.69 ms, (p50: 8100 ms, p70: 9000, p90: 9200 ms, p99: 9200 ms), latency samples: 88960
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3928.05 txn/s, latency: 8675.16 ms, (p50: 9600 ms, p70: 9700, p90: 10100 ms, p99: 10200 ms), latency samples: 139520
3. Upgrading rest of first batch to new version: f5b8dc613065c4a14ca3d5cc8ae4f880ecd53dc9
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4360.78 txn/s, latency: 7129.20 ms, (p50: 7800 ms, p70: 8500, p90: 9000 ms, p99: 9100 ms), latency samples: 91960
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4408.08 txn/s, latency: 7706.56 ms, (p50: 8700 ms, p70: 8800, p90: 9000 ms, p99: 9200 ms), latency samples: 155500
4. upgrading second batch to new version: f5b8dc613065c4a14ca3d5cc8ae4f880ecd53dc9
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7882.79 txn/s, latency: 3839.75 ms, (p50: 4400 ms, p70: 4600, p90: 4900 ms, p99: 5100 ms), latency samples: 147600
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8167.80 txn/s, latency: 4170.42 ms, (p50: 4500 ms, p70: 4700, p90: 4900 ms, p99: 5200 ms), latency samples: 271940
5. check swarm health
Compatibility test for 17540fad8e88ab5681f3a91190b9f5d37e53d2ef ==> f5b8dc613065c4a14ca3d5cc8ae4f880ecd53dc9 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on f5b8dc613065c4a14ca3d5cc8ae4f880ecd53dc9

two traffics test: inner traffic : committed: 14159.71 txn/s, submitted: 14190.01 txn/s, expired: 30.30 txn/s, latency: 2681.12 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5383840
two traffics test : committed: 99.97 txn/s, latency: 1502.76 ms, (p50: 1500 ms, p70: 1500, p90: 1700 ms, p99: 3400 ms), latency samples: 1900
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.538, avg: 1.438", "ConsensusProposalToOrdered: max: 0.304, avg: 0.301", "ConsensusOrderedToCommit: max: 0.425, avg: 0.411", "ConsensusProposalToCommit: max: 0.727, avg: 0.712"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.55s no progress at version 67267 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.72s no progress at version 1624862 (avg 0.71s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking