Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/3] Create a workflow that can automatically upgrade the sdk proto dependency. #15568

Conversation

larry-aptos
Copy link
Contributor

@larry-aptos larry-aptos commented Dec 11, 2024

Description

Release Github Action that helps update the indexer SDK proto dependency.

How Has This Been Tested?

  • Tested in this PR and looks good.
  • In this PR it's showing that the downstream action is triggered

image

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 11, 2024

⏱️ 3h 12m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-cargo-deny 26m 🟩🟩🟩🟩 (+10 more)
check-dynamic-deps 23m 🟩🟩🟩🟩🟩 (+10 more)
check-protos 15m 🟩🟩🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 12m
rust-move-tests 12m
rust-move-tests 10m
rust-move-tests 7m
general-lints 7m 🟩🟩🟩🟩🟩 (+10 more)
semgrep/ci 6m 🟩🟩🟩🟩🟩 (+10 more)
rust-move-tests 5m
rust-move-tests 3m

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@larry-aptos larry-aptos force-pushed the 12-11-create_a_workflow_that_can_automatically_upgrade_the_sdk_proto_dependency branch from 9b6de4e to a851e55 Compare December 11, 2024 22:51
@larry-aptos larry-aptos marked this pull request as ready for review December 11, 2024 22:52
@larry-aptos larry-aptos requested a review from a team as a code owner December 11, 2024 22:52
@larry-aptos larry-aptos force-pushed the 12-11-create_a_workflow_that_can_automatically_upgrade_the_sdk_proto_dependency branch from a851e55 to 10cdc8a Compare December 11, 2024 22:56
@larry-aptos larry-aptos force-pushed the 12-11-create_a_workflow_that_can_automatically_upgrade_the_sdk_proto_dependency branch 9 times, most recently from 31cfad6 to 8108ab2 Compare December 11, 2024 23:57
@larry-aptos larry-aptos changed the title Create a workflow that can automatically upgrade the sdk proto dependency. [1/3/ Create a workflow that can automatically upgrade the sdk proto dependency. Dec 11, 2024
@larry-aptos larry-aptos changed the title [1/3/ Create a workflow that can automatically upgrade the sdk proto dependency. [1/3] Create a workflow that can automatically upgrade the sdk proto dependency. Dec 11, 2024
@larry-aptos larry-aptos force-pushed the 12-11-create_a_workflow_that_can_automatically_upgrade_the_sdk_proto_dependency branch from 8108ab2 to d5b107e Compare December 12, 2024 00:48
@larry-aptos larry-aptos requested a review from aluon December 12, 2024 01:15
@larry-aptos larry-aptos force-pushed the 12-11-create_a_workflow_that_can_automatically_upgrade_the_sdk_proto_dependency branch from d5b107e to c8c5612 Compare December 12, 2024 01:29
@larry-aptos larry-aptos force-pushed the 12-11-create_a_workflow_that_can_automatically_upgrade_the_sdk_proto_dependency branch 4 times, most recently from 34bcf52 to 4ee3b13 Compare January 6, 2025 03:56
@larry-aptos larry-aptos requested a review from a team January 6, 2025 18:45
@larry-aptos larry-aptos force-pushed the 12-11-create_a_workflow_that_can_automatically_upgrade_the_sdk_proto_dependency branch from 4ee3b13 to a66ab27 Compare January 6, 2025 21:22
@rtso
Copy link
Contributor

rtso commented Jan 6, 2025

Can you share an example of the generated PR that this GHA will trigger?

@larry-aptos
Copy link
Contributor Author

Can you share an example of the generated PR that this GHA will trigger?

Done updated the PR description.

* Example PR: https://github.com/larry-aptos/aptos-indexer-processor-sdk/pull/6 

@larry-aptos larry-aptos enabled auto-merge (squash) January 6, 2025 21:39

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> a66ab272c165c938f9675b41f4e2fb8ddf3156d6

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> a66ab272c165c938f9675b41f4e2fb8ddf3156d6 (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 17210.08 txn/s, latency: 2034.87 ms, (p50: 2100 ms, p70: 2100, p90: 2400 ms, p99: 2800 ms), latency samples: 553980
2. Upgrading first Validator to new version: a66ab272c165c938f9675b41f4e2fb8ddf3156d6
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 8022.99 txn/s, latency: 3723.76 ms, (p50: 4100 ms, p70: 4500, p90: 4800 ms, p99: 5000 ms), latency samples: 150120
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 8142.02 txn/s, latency: 4143.68 ms, (p50: 4500 ms, p70: 4600, p90: 4800 ms, p99: 5100 ms), latency samples: 268280
3. Upgrading rest of first batch to new version: a66ab272c165c938f9675b41f4e2fb8ddf3156d6
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6816.66 txn/s, latency: 4431.12 ms, (p50: 5100 ms, p70: 5400, p90: 5600 ms, p99: 5600 ms), latency samples: 126140
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6156.98 txn/s, latency: 5519.03 ms, (p50: 5600 ms, p70: 6400, p90: 7100 ms, p99: 7500 ms), latency samples: 210140
4. upgrading second batch to new version: a66ab272c165c938f9675b41f4e2fb8ddf3156d6
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11598.92 txn/s, latency: 2523.82 ms, (p50: 2900 ms, p70: 3000, p90: 3100 ms, p99: 3200 ms), latency samples: 204260
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11619.71 txn/s, latency: 2832.48 ms, (p50: 3000 ms, p70: 3100, p90: 3200 ms, p99: 3700 ms), latency samples: 373940
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> a66ab272c165c938f9675b41f4e2fb8ddf3156d6 passed
Test Ok

This comment has been minimized.

This comment has been minimized.

1 similar comment

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

✅ Forge suite realistic_env_max_load success on a66ab272c165c938f9675b41f4e2fb8ddf3156d6

two traffics test: inner traffic : committed: 15381.51 txn/s, latency: 2585.49 ms, (p50: 2600 ms, p70: 2700, p90: 2700 ms, p99: 3000 ms), latency samples: 5848520
two traffics test : committed: 100.00 txn/s, latency: 1315.30 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 2000 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.530, avg: 1.484", "ConsensusProposalToOrdered: max: 0.285, avg: 0.280", "ConsensusOrderedToCommit: max: 0.291, avg: 0.283", "ConsensusProposalToCommit: max: 0.571, avg: 0.563"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.51s no progress at version 6628710 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.54s no progress at version 2928305 (avg 0.54s) [limit 16].
Test Ok

@larry-aptos larry-aptos merged commit e3fdc51 into main Jan 7, 2025
85 of 88 checks passed
@larry-aptos larry-aptos deleted the 12-11-create_a_workflow_that_can_automatically_upgrade_the_sdk_proto_dependency branch January 7, 2025 01:08
@yuunlimm yuunlimm restored the 12-11-create_a_workflow_that_can_automatically_upgrade_the_sdk_proto_dependency branch February 7, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants